feat: add submission notification #3018
Conversation
| ->setParameter('team', $team) | ||
| ->andWhere('s.submittime < c.endtime') | ||
| ->andWhere('j.valid = 1') | ||
| ->andWhere('j.seen = 0'); |
There was a problem hiding this comment.
is there a migration missing? seen doesn't exist yet, does it?
There was a problem hiding this comment.
domjudge/webapp/src/Entity/Judging.php
Lines 118 to 120 in 4398ae5
But this may not be important, because the logic of whether to send notifications does not look at this field, (which is at sendNotification @ domjudge.js)
There was a problem hiding this comment.
BTW, this SQL query is the same as the one a user access /api/contests/:cid/judgements, except it filters out entries they have ever seen (it will be marked as seen when they click the submission).
Therefore, it is also feasible to implement it directly on the frontend js instead of adding a function to the /update endpoint.
There was a problem hiding this comment.
When are we setting the seen to true? I assume we already do this.
cubercsl
force-pushed
the
feat/submission-notification
branch
2 times, most recently
from
d6d9118 to
32b9f38
Compare
cubercsl
force-pushed
the
feat/submission-notification
branch
from
32b9f38 to
44d7fee
Compare
|
Have tested in some ICPC Asia East Reginal Contests this month. Here is a reaction desktop video for selected team open this feature. reaction-desktop.webm |
4 participants
Related to #2252, just for a POC now.
Lack of testing, and I'm not sure how much impact such a query would have on performance when there are a large number of teams polling for updates.